Why is Custom Confirmation Dialog for 'Remove Hold' on ARInvoice Not Preventing the Action in 24R2?

Try this instead:

public delegate IEnumerable ReleaseFromHoldDelegate(PXAdapter adapter);
[PXOverride]
public IEnumerable ReleaseFromHold(PXAdapter adapter, ReleaseFromHoldDelegate baseMethod)
{
    ARInvoice doc = Base.Document.Current;

    if (doc is object)
    {
        // Show confirmation dialog
        if (Base.Document.Ask("Confirm Freight Surchage,
            "Please confirm the Freight Surcharge Amount before proceeding. Do you want to continue?",
            MessageButtons.YesNo) == WebDialogResult.Yes)
        {
            // Proceed with the original Remove Hold logic
            return baseMethod(adapter);
        }
    }

    return adapter.Get(); // Expected to cancel the action
}

I believe the reason is because when using a dialog, the method will get called twice, once to open the dialog and once when the result is provided. The second time (I think), in your code, it will bypass the dialog and simply execute the default value, which is baseMethod.

This code will default to falling through and only execute if the dialog is confirmed ‘yes’.

Hi ​@darylbowman , I already tried the way you suggested earlier, but I tested it again directly with your solution. It's still showing the same issue. Could this be due to changes in the updated workflow engine in 24R2?

​@malinthawarnakulasooriya08 

Personally, I like doing this kind of stuff through the workflow API.

I haven’t updated a transition rather, removed the original and added a modified one.

An issue with this is that it updates the ‘System’ workflow and is harder to access and modify in the future if the person modifying does not have access to your source code.

​@darylbowman ​@malinthawarnakulasooriya08 

Just for reference, most actions which are used in workflows “don’t do anything” in the graph, their logic is usually in the workflow.

Thank you so much, ​@darylbowman  and ​@aiwan  , for your valuable guidance and feedback. I’m new to workflow customizations, and I’ll try to check it from scratch. Can you please let me know if this customization is possible through the Acumatica Customization Project Editor?

​@malinthawarnakulasooriya08 

You could try with the Editor, but I believe you would have to first mark the transition as inactive, then create a new action with your custom dialogue box, then create a new transition in which you use the new action you created.

Thank you so much ​@aiwan for the valuable feedback.