Popup Message Triggering Unexpectedly on Shipments Screen

Maybe include another condition checking whether the cache is inserted? It should only pop up if it is not in the inserted status right?

Edit: Something like this: Base.Document.Cache.GetStatus(Base.Document.Current) != PXEntryStatus.Inserted

Hi ​@DrewNisley, 

Thanks for the response!

Yes, I tried adding a check to see if the record status is Inserted using the following code:

 private bool _prompted = false;
        protected void SOShipment_RowSelected(PXCache cache, PXRowSelectedEventArgs e, PXRowSelected InvokeBaseHandler)

        {
            if (InvokeBaseHandler != null)
               InvokeBaseHandler(cache, e);
                var row = (SOShipment)e.Row;
            if (row == null || _prompted || Base.IsContractBasedAPI || Base.IsImport) return;

            var ext = PXCache<SOShipment>.GetExtension<SOShipmentExt>(row);

            PopupNoteManager.Message = null;
            bool isNew = (cache.GetStatus(row) == PXEntryStatus.Inserted);
            if (row.ShipmentNbr != null && !_prompted && !string.IsNullOrWhiteSpace(ext?.UsrNotes) && !isNew)
            {
                _prompted = true; // ensure it runs only once per view

                PopupNoteManager.Message = "Check Notes.";

            }
        }

It still is popping up the box after adding that?

Yes, I’ve tested that, but the popup still appears for the <NEW> record when navigating using the arrow buttons (not via the Add New (+) button).

I debugged the code and found that when navigating from a record that has a Notes value, the system seems to retain the previous record's data temporarily. In the debugger, I can see that the ShipmentNbr is still populated with the previous record’s value, and since that record had Notes, the popup logic gets triggered again.

So essentially, the popup is being shown based on the old record’s data while navigating to the blank record. Still exploring how to best handle this scenario.

Have you debugged to see why it thinks that the UsrNotes field isn’t blank? It should be blank for all newly created shipments, so I’m not sure as to why it’s getting past that point.

Edit: Oops, hand’t refreshed the screen to see your reply.

I did this exact things several months ago. I'm not in a position to check how I handled it. I'll let you know next week.

I’m a bit confused, because while I remember experiencing exactly what you are describing, the code that I found doesn’t have any distinct circumventions of that. If I remember correctly, using the cache to store the shown flag solved the problem.

Here’s the essence of my code:

protected virtual void _(Events.RowSelected<SOShipment> e, PXRowSelected b)
{
    b?.Invoke(e.Cache, e.Args);

    SOShipment row = e.Row;
    if (row is null) return;

    var rowExt = row?.GetExtension<DXSOShipmentExt>();

    if (!Base.IsContractBasedAPI && !Base.IsProcessing &&
        !Base.IsImport && !Base.IsExport)
    {
        string popupMessage = "";

        if (rowExt?.UsrDXShipNoteShown == false)
        {
            Base.Document.SetValueExt<DXSOShipmentExt.usrDXShipNoteShown>(row, true);

            if (!string.IsNullOrWhiteSpace(popupMessage))
                PopupNoteManager.RegisterText(e.Cache, row, "ShipmentNbr", popupMessage);
        }
    }
}

Having spent some time with the ‘notes’ mechanism, I can confidently say that while I don’t completely understand how it’s working, there are some very interesting ‘goings on’ in the backend to make the notes work and any oddities can be chalked up to that.

Hi ​@darylbowman, 

Thank you so much for your response — I really appreciate it.

Yes, my scenario is slightly different. I want to show a popup for the current shipment only when accessing it from the Shipments GI or while navigating using the arrows. The popup should appear only if the custom field UsrNotes has a value for the current shipment.

Right now, it’s working fine for me except in one case:
When the record on screen is <NEW>, and the previously accessed record had a value in UsrNotes, the popup still shows. In this case, I don’t want the popup to appear, because the current shipment is a new (unsaved) record.

How is it different?

Thank you for sharing your solution with the community ​@Nilkanth Dipak!