Illegal Characters in path when customize save file in Invoice

Hi ​@vannakheng,
 

Hi ​@vannakheng 

It looks like file is saving before the invoice number is generated, illegal characters include “<>” could you maybe move this to override “Remove Hold” or “Release”? This will ensure you have a invoice number in the DB.

I believe “\” is also an illegal character.

Hope this helps,

Aleks

yes If move code to on release, it’s working fine no problem. But my logic want to generate file when prepare invoice from shipment. Can we change the file path when we save fileinfo.

​@vannakheng 

If you want to do this when the invoice is prepared, you could try to override the “Prepare Invoice” action and execute your code after the initial Base.Save.Press(); is called, this should ensure that the there is an invoice nbr generated.

Aleks

Hi ​@vannakheng ,

You’re running into an “Illegal Characters in Path” error because the file name you generate sometimes includes characters that Windows (and other file systems) won’t accept in a path. Even if your DateTime format looks okay, local or regional settings can insert slashes or other characters.

For example:

var client = new RestClient();
var request = new RestRequest("https://material.angular.io/assets/img/examples/shiba2.jpg", Method.GET);

byte[] data = client.DownloadData(request);

// Construct a safe file name using a fixed date/time format
string fileName = $"AR_{DateTime.Now:yyyyMMdd_HHmmss}.jpg";

PX.SM.FileInfo file = new PX.SM.FileInfo(fileName, null, data);

var uploadFileMaintenance = PXGraph.CreateInstance<UploadFileMaintenance>();
uploadFileMaintenance.SaveFile(file);

PXNoteAttribute.AttachFile(Base.Document.Cache, Base.Document.Current, file);

ARRegisterExt aRInvoiceExt = PXCache<ARRegister>.GetExtension<ARRegisterExt>(Base.Document.Current);
aRInvoiceExt.UsrWingUID = file.UID;

This should eliminate the “Illegal Characters in Path”

If I were to write something that works always, I would create a method and pass the string I want to verify and return a clean and valid string. This will do the work

private string ReplaceInvalidChars(string validationString)
{
    char[] invalidChars = Path.GetInvalidFileNameChars();
    //If you want to replace the inavalid characters with a valid character like dash
    return new string(validationString.Select(chr => invalidChars.Contains(chr) ? '-' : chr).ToArray());
    //If you want to remove the invalid characters
    return new string(validationString.Where(chr => !invalidChars.Contains(chr)).ToArray());
}