How to Resolve Duplicate Loop Execution in Persist Method

Hi ​@RKarunarathne51 ,

try with the below code and see if it works.

[PXOverride]
public virtual void Persist(Action baseMethod){

       
        var multiplicationFactor = contractExt.UsrAdjustmentDays //Custom field where user enters an integer. I retrieve this value to here
            if (TransactionLines != null){
                    foreach (ARTran TransactionLine in Base.Transcations.Select())
                    {
                       TransactionLine.CuryUnitPrice = TransactionLine.CuryUnitPrice * multiplicationFactor;
                       Base.Transactions.Update(TransactionLine);
                    }

            }

baseMethod();
}

Hello - difficult to say why the Persist method is being called mulitple times but I think you need to deal with it and adjust the business logic of your code.

The following line…
TransactionLine.CuryUnitPrice = TransactionLine.CuryUnitPrice * multiplicationFactor; 
...will continue to increase the value of CuryUnitPrice over and over again when Persist is called and I often find Persist is call more often than I expect.

You should perhaps look for a way to store the original CuryUnitPrice in a custom field and use something like the following to update CuryUnitPrice.
TransactionLine.CuryUnitPrice = TransactionLine.usrOrigCuryUnitPrice * multiplicationFactor; 

I don’t think your code is causing Perist to be called multiple times. You could comment out the following line and step through the code in visual studio to do sure.
Base.Transactions.Update(TransactionLine);
In anycase, you should look to rework the business logic so that multiple calls of Persist don’t break your calculation.

Good luck
Steve

Hi ​@praveenpo ,
I tried but same result

Hi ​@stephenward03 ,
Actually, there are many conditions that must be met for the above for loop to execute. I didn't include them because it would have made the code too long. The for loop executes correctly twice when all the conditions are met. I can’t find a way to stop it

Without sharing the conditions I don’t think anyone can help you further. You cannot stop Persist firing multiple times, the code you have shared will update the CuryUnitPrice multiple times.

If you want to stop your loop from being called mulitple times then it sounds like more conditions are needed. Even so, a better solution will be to rework the business logic as suggested earlier.

Hi ​@RKarunarathne51 

Instead of modifying ARTran records within Persist handle updates inside RowPersisting to ensure the calculation happens only once.

public class ARInvoiceEntry_Extension : PXGraphExtension<ARInvoiceEntry>
{
protected void ARTran_RowPersisting(PXCache sender, PXRowPersistingEventArgs e)
 {
     ARTran row = (ARTran)e.Row; if (row == null) return;
    var doc = Base.Document.Current; var contractExt = doc.GetExtension<YourCustomExtension>();

    // Replace with your extension name

  if (contractExt?.UsrAdjustmentDays != null)

    {
       row.CuryUnitPrice = row.CuryUnitPrice * contractExt.UsrAdjustmentDays;

    }

  }

}