Hi @joe21 

I recommend to have your logic in a separate process that look after those invoices. ReleaseInvoice can be called from multiple places and that added complexity can be a cause of bugs or unintended behaviors (Please see this similar case: How to get the error messages?

@joe21  it seems to me that removing an APTran record and creating a new one may compromise the data integrity. E.g. generated GLTrans have specific relations to initial APTrans. Also, APTran can be related to a project, project task, there may be specific tax involved or a discount. 

I’d recommend to rethink the approach completely and avoid changing APtrans after document release.

@Leonardo Justiniano The ReleaseInvoice process is the only place I can call to adjust the APTran lines prior to them being posted to the GL.  The lines in the APTran table affect the GLTran table.

I do the same check at the top of my override as is used in the original method:

if (doc.Released != true && doc.DocType == "INV" && (!isPrebooking || doc.Prebooked != true))

As such, the only time this override will call my method to allocate is when it is ok to be released.    

I actually want this override called no matter where an AP document gets released.  The ONLY time that it will actually call my custom method to allocate is if the APTran record (original one) that was imported includes a value in the AllocationIDUsed field.

I read the other thread.  The solutions there don’t look like would be able to handle my use case.

I agree with Dimitrii. Too many moving pieces at that moment.

Actually, I see that you are doing that before the release. Still, there are some questions. 

E.g. what happens if the release fails? Do you want to rollback your “allocations”? 

I think what you can do in AllocateLine is to create the APInvoiceEntry graph, set the document as current, click your custom button, save it. 

@Dmitrii Naumov   If I am changing the APTran table before it is actually released, I would think that any calculations on the invoice would be handled as part of the release process. At the start of the override, nothing has actually been created in the GL.  Note that I do copy over the project ID to the new lines.  I also allocate any affected financial values such as discounts.  

From debugging, when the delegate fires, the only thing in it with any values is the doc object which is the “header” record.  

The only other option I can think of is to create a completely standalone operation that you would run on the APTran table before you release the invoices.  I think maybe that is the best approach.  Let me know if you all agree with that.

If the customer forgets to run the “pre-release” process before releasing invoices, I guess that will be on them. :-)

That is actually what I am trying right now!  :-)

        APInvoiceEntry apInvoiceEntryGraph = PXGraph.CreateInstance<APInvoiceEntry>();

            apInvoiceEntryGraph.GetExtension<APInvoiceEntry_Extension>();

            apInvoiceEntryGraph.Transactions.Current = 
I’m not sure what to do right now to set the current transaction.  If you know what goes after the equal sign, that will save me about 4 hours…  HA!

If the release fails, it is ok.  I still want the lines allocated.  I’m thinking I need to add a bit field to the APTran record to indicate it has already been allocated so it doesn’t do it twice if the release fails for some reason.

UPDATE:  I think I need to use 
            apInvoiceEntryGraph.Document.Current = 

to set the graph to the record I want to process.  I just can’t figure out how to set RefNbr to the current refnbr of the doc passed to my method.

@Dmitrii Naumov 

If I am able to make reference to my graph extension, do I have to instantiate it for each invoice or can I create it at the “top level” somehow and just re-use it?

I’m clicking Refresh on this screen every 10 seconds, like I’m waiting for a girl to tell me if she will go on a date with me.  

So I think it should be something like that:

APInvoiceEntry apInvoiceEntryGraph = PXGraph.CreateInstance<APInvoiceEntry>();

apInvoiceEntryGraph.Document.Current = PXSelect<APInvoice, Where<APInvoice.docType, Equal<Required<APInvoice.docType>>, And<APInvoice.refNbr, Equal<Required<APInvoice.refNbr>>>>>.Select(apInvoiceEntryGraph );
var extension= apInvoiceEntryGraph.GetExtension<APInvoiceEntry_Extension>();
extension.AllocateLines.Press();
apInvoiceEntryGraph.Save.Press();

In the APInvoiceEntryExtension you need something like that:

public PXAction<APTran> AllocateLine;
 PXButton(CommitChanges = true)]
 PXUIField(DisplayName = "Allocate Line", Enabled = false, Visible = false)]
protected void allocateLine()
{

	APTran currentItem = this.Base.Transactions.Current;
    PerformAllocation(currentItem);
}

public PXAction<APTran> AllocateLines;
 PXButton(CommitChanges = true)]
 PXUIField(DisplayName = "Allocate All Lines", Enabled = false, Visible = false)]
protected void allocateLines()
{

    foreach (APTran apTran in Base.Transactions.Select())
	{
         PerformAllocation(apTran);
    }

}

public void PerformAllocation(APTran currentItem )
{
	if (currentItem == null) return;

	if (currentItem.CuryLineAmt == 0) return;

	APTranExt itemExt = PXCache<APTran>.GetExtension<APTranExt>(currentItem);

	if (itemExt.UsrAllocationID == null) 
	{
		throw new Exception("You need to select an Allocation Template");
	}

	int itemCounter = 0;
	int itemCount = 0;
	decimal? balanceToAllocate = currentItem.CuryLineAmt;
	decimal? balanceToAllocateDiscount = currentItem.CuryDiscAmt;

	foreach (var detail in SelectFrom<ICAllocationAccounts>.InnerJoin<ICAllocationCode>.
		On<ICAllocationCode.allocationID.IsEqual<ICAllocationAccounts.allocationID>>.
		Where<ICAllocationCode.allocationID.IsEqual<@P.AsInt>>.
		View.Select(Base, itemExt.UsrAllocationID))
	{
		itemCount++;
	}

	this.Base.Transactions.Delete(currentItem);

	ICAllocationCode code = SelectFrom<ICAllocationCode>.
		Where<ICAllocationCode.allocationID.IsEqual<@P.AsInt>>.
		View.Select(Base, itemExt.UsrAllocationID);


	foreach (ICAllocationAccounts detail in SelectFrom<ICAllocationAccounts>.InnerJoin<ICAllocationCode>.
	On<ICAllocationCode.allocationID.IsEqual<ICAllocationAccounts.allocationID>>.
	Where<ICAllocationCode.allocationID.IsEqual<@P.AsInt>>.
	View.Select(Base, itemExt.UsrAllocationID))
	{
		itemCounter++;

		APTran newRow = (APTran)this.Base.Transactions.Cache.CreateCopy(currentItem);

		newRow.LineNbr = null;
		newRow.TranID = null;
		newRow.NoteID = null;

		if (itemCount == itemCounter)
		{
			newRow.CuryLineAmt = balanceToAllocate;

			if (currentItem.CuryDiscAmt != null && currentItem.CuryDiscAmt > 0)
			{
				newRow.CuryDiscAmt = balanceToAllocateDiscount;
				newRow.CuryTranAmt = newRow.CuryLineAmt - newRow.CuryDiscAmt;
			}
			else
			{
				newRow.CuryTranAmt = balanceToAllocate;
			}
		}
		else
		{
			newRow.CuryLineAmt = Math.Round((decimal)((detail.Percent / 100) * currentItem.CuryLineAmt), 2);
			balanceToAllocate -= (decimal)newRow.CuryLineAmt;

			if (currentItem.CuryDiscAmt != null && currentItem.CuryDiscAmt > 0)
			{
				newRow.CuryDiscAmt = Math.Round((decimal)((detail.Percent / 100) * currentItem.CuryDiscAmt), 2);
				balanceToAllocateDiscount -= (decimal)newRow.CuryDiscAmt;
				newRow.CuryTranAmt = newRow.CuryLineAmt - newRow.CuryDiscAmt;
			}
			else
			{
				newRow.CuryTranAmt = newRow.CuryLineAmt;
			}
		}

		if (currentItem.Qty != null && currentItem.Qty > 0)
		{
			newRow.Qty = Math.Round((decimal)((decimal)(detail.Percent / 100) * currentItem.Qty), 2);
		}

		if (code.DescriptionSource == DescriptionSourceType.FromDocument)
		{
			newRow.TranDesc = currentItem.TranDesc;
		}
		else
		{
			newRow.TranDesc = code.TranDescr;
		}

		newRow.BranchID = detail.BranchID;

		if(newRow.InventoryID == null)
		{
			newRow.SubID = detail.AccountSubID;
		}
		else
		{
			newRow.TranDesc = currentItem.TranDesc;
		}

		APTranExt itemExt2 = PXCache<APTran>.GetExtension<APTranExt>(newRow);
		itemExt2.UsrAllocationIDUsed = itemExt.UsrAllocationID;
		itemExt2.UsrAllocationID = null;

		this.Base.Transactions.Cache.Update(newRow);
		//this.Base.Transactions.Cache.Insert(newRow);
	}
}

@Dmitrii Naumov 

I actually just refactored my graph extension to do what you just showed above.

Thank you so much for this.  I will plagiarize your code if you don’t mind!  

Awesome help when I really needed it!!